-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce S3OutputStream that uploads data to S3 directly #45
Conversation
twz123
commented
Jun 29, 2015
- S3OutputStream uses multipart uploads to transfer data to S3 without storing it on local disk first
- FileSystemProvider returns this implementation for new OutputStreams instead of S3SeekableByteChannel if possible
- S3OutputStream uses multipart uploads to transfer data to S3 without storing it on local disk first - FileSystemProvider returns this implementation for new OutputStreams instead of S3SeekableByteChannel if possible
Looks great, thanks!. Do you do some performance tests? |
No, I didn't measure performance. The intention for this was very constrained local disk space. So, when producing large amounts of data to be stored on S3 in a streaming-like fashion, that data doesn't have to be written to disk before. The local disk would have been too small for this anyways. |
@jarnaiz How do you usually measure performance. Do you have any framework, or a best practice? What measures would you like to see here? |
Hi @twz123 I dont have experience with any benchmark framework. I usually do manual testing printing the response time of the operation and compare the result with the old version. PD: quit any downloader and you need a stable internet connection ;) Thanks! |
519195e
to
9216d8b
Compare
👍 |
Hi, @twz123 , we would like to thank you for your work on this and are sad to see that it was not accepted and merged in this project. However, for anyone interested, we've used this as inspiration of how to implement it in our spin-off (rebranded fork) -- s3fs-nio where we have now also migrated our code to AWS SDK v2 (see carlspring/s3fs-nio#63) . As this upstream is now clearly dead (#135), please feel free to check out our work in carlspring/s3fs-nio#95. We would like to rebuild a community around the s3fs-nio and would be thrilled, if you'd like to join us in our efforts to build a stable library that is well-maintained, documented and regularly released. Kind regards, Martin Todorov |
Closing this, as it's solved in the successor project. 👍 |
Thanks, @twz123 ! :) |