Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Timeline): show loading state if not played but duration is infinity #53

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

timaramazanov
Copy link
Collaborator

@timaramazanov timaramazanov commented Jul 2, 2024

Instead of hiding timeline when duration === Infinity - show loading state, and hide timeline completely only if played is true and duration === Infinity

@Bitaru
Copy link
Collaborator

Bitaru commented Jul 2, 2024

🎉 This issue has been resolved in version 1.1.2-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Collaborator

@Bitaru Bitaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ looks good

@timaramazanov timaramazanov merged commit a81944a into main Jul 2, 2024
1 check passed
@Bitaru
Copy link
Collaborator

Bitaru commented Jul 2, 2024

🎉 This issue has been resolved in version 1.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Bitaru Bitaru added the released label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants