Synced function symbols from decomp #187
Conversation
AnonymousRandomPerson
commented
Sep 7, 2023
AnonymousRandomPerson
commented
- Core functions that are standard across most DS/NitroSDK games (e.g., crt0 init functions).
- Veneers auto-detected by Ghidra while setting up the decomp.
AnonymousRandomPerson
force-pushed
the
master
branch
2 times, most recently
from
8ad4480
to
4c01431
Compare
AnonymousRandomPerson
force-pushed
the
master
branch
from
51f071f
to
f401d4b
Compare
| void SvcWaitByLoop(void); | ||
| void SvcSoftReset(void); | ||
| void SvcCpuSet(void); | ||
| void _start(void); | ||
| void MIiUncompressBackward(void); | ||
| void do_autoload(void); | ||
| void StartAutoloadDoneCallback(void); | ||
| void OSiReferSymbol(void); | ||
| void NitroMain(void); |
There was a problem hiding this comment.
Do you know if these are (mostly) the only core functions with weird naming? It seems like after these you get into the allocator functions. If these are the only exceptions maybe it might make more sense to implement an exception list for the case checker so we can use the real names.
There was a problem hiding this comment.
These are not the only ones. I've seen this naming convention in some of the library code, and the number of functions would make an exception list grow very large.
I don't personally like this naming convention of mixing case with domain_action, but it is a real naming convention used by some C programming circles (e.g., pret/pokeheartgold#213). It may be worth supporting this style outright, rather than making exceptions.
There was a problem hiding this comment.
I would need to see more examples. This kind of mixed case convention seems extremely permissive, because domain can be anything (MIi == PascalCase, SVC == SCREAMING_SNAKE_CASE, _start == snake_case), so a sufficiently flexible check would have to accept almost all names except maybe camelCase and constructs like UPPERlower. It's not something I'd really be keen on implementing checks for. You might as well just turn off naming checks at that point.
Maybe let's just leave it as the converted PascalCase names for now. You're maintaining a list if the mixed case ones, so it should be easy to revisit this if we start finding more of these.
There was a problem hiding this comment.
If you search for jn_spl.o in this map file, that section of the file has more examples.
I think _start_AutoloadDoneCallback is a special case because it is related to the _start function, which is hard-coded to be the entry point of the program regardless of naming convention. Ignoring that, the convention seems to be PascalCase between the underscores, allowing consecutive capitals for abbreviations. This at least allows some restrictions.
I'm good with keeping the converted names for now. I'm not very interested in the library code, but if somebody else starts extracting them then we can revisit this.
AnonymousRandomPerson
force-pushed
the
master
branch
from
eca6963
to
14e7373
Compare
