Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On first map entry, default marker mode config panel should be fully open; plot visible in all menu "modes"; improve general persistence #403

Closed
2 of 3 tasks
bobular opened this issue Aug 3, 2023 · 2 comments · Fixed by #399
Assignees
Labels
enhancement New feature or request

Comments

@bobular
Copy link
Member

bobular commented Aug 3, 2023

  • entry behaviour as in title
  • floating plots should be visible in any menu mode (just remove the conditional rendering)
  • Above done, but (I don't think) by me (Connor)
  • improve general persistence (optional - pls make another ticket if not doing)

As decided here
https://veupathdb.atlassian.net/wiki/spaces/WG/pages/337117185/2023-07-27+Map+UX#default-panel

Best to branch from/target to this branch https://github.com/VEuPathDB/web-monorepo/tree/map-collection-variable-map-type if it's still unmerged (see #399)

I'm currently assuming that the default marker mode is the first marker mode (hardcoded in client nav panel, IIRC).

When the user first enters the map, the full marker panel should be open (in "Markers" tab).

Note that all UI state should be preserved in the user database. At the moment it's a bit hit and miss.

For example if I open a supporting plot, and minimise the menu (leaving the plot on screen), wait for network requests to stop, then reload the page, the page re-opens with the menu open (it should be minimised).

The goal is for the map to look identical upon reloading (or opening a share link) if in the same-sized browser window, and only slightly different if in a different size/shape window (e.g. legend and plot positions).

@bobular bobular added the enhancement New feature or request label Aug 3, 2023
@bobular bobular changed the title On first map entry, default marker mode config panel should be fully open; improve general persistence On first map entry, default marker mode config panel should be fully open; plot visible in all menu "modes"; improve general persistence Aug 4, 2023
@chowington chowington self-assigned this Aug 14, 2023
@chowington
Copy link
Member

For the second task, I assume that we don't want the vizs for a different map type to show for the currently-selected map type. Eg, if I have a viz open in the donut map type, when I click over to the bubble map type, the viz should disappear

@chowington
Copy link
Member

Assigning to @dmfalke as merging his PR (#399) will fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants