Side panel UX improvements #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chowington
changed the title
3 tasks
bobular
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
Looks great. The functionality works for the marker mode and menu/drawer open/hidden state is preserved on page refresh.
I made a comment for the follow-on work #444 (comment)
| @@ -222,6 +224,7 @@ export function useAppState(uiStateKey: string, analysisState: AnalysisState) { | |||
| ), | |||
| setMarkerConfigurations: useSetter('markerConfigurations'), | |||
| setBoundsZoomLevel: useSetter('boundsZoomLevel'), | |||
| setIsSidePanelExpanded: useSetter('isSidePanelExpanded'), | |||
| setIsSubsetPanelOpen: useSetter('isSubsetPanelOpen'), | |||
There was a problem hiding this comment.
I know it's outside the scope of this PR but isSubsetPanelOpen seems to be unused.
If you agree, maybe we could remove it here, rather than make a trivial tech debt ticket?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #403
I'm marking this as ready to merge while we're still considering the idea of general UI persistence. Further work can be in another ticket.