Add to_json method for exporting Entry metadata to JSON #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexDo1
added
enhancement
mmaelicke
requested changes
Jan 22, 2024
Comment on lines
+423
to
+429
| class DictToSerializableJsonEncoder(json.JSONEncoder): | ||
| def default(self, obj): | ||
| if isinstance(obj, Decimal): | ||
| return str(obj) | ||
| if isinstance(obj, dt): | ||
| return obj.isoformat() | ||
| return super().default(obj) |
There was a problem hiding this comment.
Let's define this in some kind of utility file, so that other models can use it as well.
| class DictToSerializableJsonEncoder(json.JSONEncoder): | ||
| def default(self, obj): | ||
| if isinstance(obj, Decimal): | ||
| return str(obj) |
There was a problem hiding this comment.
I think it would make more sense to convert the Decimal to a float, right?
Comment on lines
+435
to
+436
| with open(path, 'w') as f: | ||
| json.dump(entry_dict, f, indent=4, cls=DictToSerializableJsonEncoder) |
There was a problem hiding this comment.
Ah ok.
Other option is to keep the writing to file out of meta catalog and implement the class directly into the tool, where it is used. What do you think?
|
We decided not to take this update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to go for a new method
Entry.to_jsonfor serializable entry-to-json-export. I think that's easier than trying to fix theexportextension.The created json should be serializable as I convert non-json datatypes to json datatypes with a custom JsonEncoder.
If we want to go for another way, we can revert this, but for now this should work.