Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

99 health query format #106

Merged
merged 3 commits into from
Mar 6, 2024
Merged

99 health query format #106

merged 3 commits into from
Mar 6, 2024

Conversation

jthomas462
Copy link

Created a health query format, updated devices. py and init.py for formats

@jthomas462 jthomas462 added feature new functionality refactor rewriting or reorganizing existing code labels Mar 1, 2024
@jthomas462 jthomas462 requested review from panyab and IonLi09 March 1, 2024 04:28
Copy link
Contributor

@panyab panyab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First, git pull on your branch so that it is up to date with main. Second, can you add a def eq(self, other) function (look at Ions for an example). Push your new changes

Copy link
Contributor

@panyab panyab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@panyab panyab merged commit 0a9c1ce into main Mar 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new functionality refactor rewriting or reorganizing existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants