Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Alert): Pass close callback to action #6728

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

mendrew
Copy link
Contributor

@mendrew mendrew commented Mar 20, 2024


Описание

Даём возможность закрыть Alert по клику на action, если autoCloseDisabled: true, передавая close функцию как аргумент в вызов action.

Copy link
Contributor

github-actions bot commented Mar 20, 2024

size-limit report 📦

Path Size
JS 356.43 KB (+0.01% 🔺)
JS (gzip) 108.69 KB (+0.01% 🔺)
JS (brotli) 89.84 KB (+0.06% 🔺)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 261.59 KB (0%)
CSS (gzip) 34.34 KB (0%)
CSS (brotli) 27.82 KB (0%)

Copy link

codesandbox-ci bot commented Mar 20, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Mar 20, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Mar 20, 2024

👀 Docs deployed

Commit ddc39cd

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.38%. Comparing base (cb0cc18) to head (ddc39cd).
Report is 18 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6728   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files         336      336           
  Lines       10359    10359           
  Branches     3469     3469           
=======================================
  Hits         8534     8534           
  Misses       1825     1825           
Flag Coverage Δ
unittests 82.38% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mendrew mendrew marked this pull request as ready for review March 21, 2024 10:50
@mendrew mendrew requested a review from a team as a code owner March 21, 2024 10:50
SevereCloud
SevereCloud previously approved these changes Mar 25, 2024
@mendrew mendrew marked this pull request as draft March 25, 2024 11:44
@mendrew mendrew marked this pull request as ready for review March 26, 2024 11:45
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mendrew mendrew merged commit 3fb1779 into master Mar 27, 2024
49 checks passed
@mendrew mendrew deleted the mendrew/6722/feat/Alert/pass-close-handler-to-action branch March 27, 2024 09:42
@Semigradsky
Copy link
Contributor

@mendrew что-то уже v6.0.3, а этих изменений всё нет...

@Semigradsky
Copy link
Contributor

@SevereCloud
Copy link
Contributor

@mendrew что-то уже v6.0.3, а этих изменений всё нет...

Эти изменения будут доступны в 6.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Alert]: дать вручную закрыть алерт по клику по actionу
5 participants