-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Alert): Pass close callback to action #6728
feat(Alert): Pass close callback to action #6728
Conversation
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit ddc39cd |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6728 +/- ##
=======================================
Coverage 82.38% 82.38%
=======================================
Files 336 336
Lines 10359 10359
Branches 3469 3469
=======================================
Hits 8534 8534
Misses 1825 1825
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@mendrew что-то уже |
Эти изменения будут доступны в 6.1.0 |
Описание
Даём возможность закрыть Alert по клику на action, если
autoCloseDisabled: true
, передаваяclose
функцию как аргумент в вызовaction
.