Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FormItem): sync margin with design system value #6753

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

BlackySoul
Copy link
Contributor


- [ ] Unit-тесты

  • e2e-тесты

- [ ] Дизайн-ревью

- [ ] Документация фичи

Описание

В дизайнс-системе отступы между FormItem равен 16px

Sorry, something went wrong.

@BlackySoul BlackySoul requested a review from a team as a code owner March 25, 2024 10:04
@github-actions github-actions bot added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Mar 25, 2024
Copy link
Contributor

size-limit report 📦

Path Size
JS 356.88 KB (0%)
JS (gzip) 108.94 KB (0%)
JS (brotli) 90.06 KB (0%)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 261.8 KB (0%)
CSS (gzip) 34.37 KB (+0.01% 🔺)
CSS (brotli) 27.88 KB (+0.08% 🔺)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit c57a18d

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.38%. Comparing base (4129e4d) to head (c57a18d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6753   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files         336      336           
  Lines       10359    10359           
  Branches     3469     3469           
=======================================
  Hits         8534     8534           
  Misses       1825     1825           
Flag Coverage Δ
unittests 82.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BlackySoul BlackySoul merged commit 6175eba into master Mar 25, 2024
26 checks passed
@BlackySoul BlackySoul deleted the fix/6752/FormLayoutGroup_fix_formitem_margin branch March 25, 2024 11:22
vkcom-publisher pushed a commit that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
None yet
3 participants