Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Gallery): add rtl support #8085

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

feat(Gallery): add rtl support #8085

wants to merge 8 commits into from

Conversation

EldarMuhamethanov
Copy link
Contributor

  • Unit-тесты
  • e2e-тесты
  • Release notes

Описание

Сейчас компонента Gallery не поддерживает отображение в rtl режиме. Нужно добавить поддержку этого режима

Изменения

  • Доработал логику компонента. Добавил поддержку rtl
  • Добавил тесты для функционала с rtl
  • Добавил скриншоты с rtl

Release notes

Улучшения

  • Gallery: Добавлена поддержка rtl

@EldarMuhamethanov EldarMuhamethanov added this to the v7.1.0 milestone Dec 16, 2024
@EldarMuhamethanov EldarMuhamethanov self-assigned this Dec 16, 2024
@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner December 16, 2024 09:55
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024 •
edited
Loading

size-limit report 📦

Path Size
JS 393.28 KB (+0.25% 🔺)
JS (gzip) 119.44 KB (+0.37% 🔺)
JS (brotli) 98.29 KB (+0.46% 🔺)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 344.18 KB (+0.05% 🔺)
CSS (gzip) 42.66 KB (+0.04% 🔺)
CSS (brotli) 34.01 KB (-0.01% 🔽)

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Dec 16, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024 •
edited
Loading

e2e tests

Playwright Report

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024 •
edited
Loading

👀 Docs deployed

Commit 722f955

@codecov Codecov
Copy link

codecov bot commented Dec 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.11765% with 7 lines in your changes missing coverage. Please review.

Project coverage is 95.49%. Comparing base (d5629e8) to head (5968168).

Files with missing lines Patch % Lines
...ckages/vkui/src/components/CarouselBase/helpers.ts 91.22% 5 Missing ⚠️
.../vkui/src/components/CarouselBase/CarouselBase.tsx 98.07% 1 Missing ⚠️
packages/vkui/src/helpers/getValueByCheckedKey.ts 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8085      +/-   ##
==========================================
- Coverage   95.49%   95.49%   -0.01%     
==========================================
  Files         403      404       +1     
  Lines       11456    11513      +57     
  Branches     3781     3804      +23     
==========================================
+ Hits        10940    10994      +54     
- Misses        516      519       +3
Flag Coverage Δ
unittests 95.49% <94.11%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inomdzhon inomdzhon modified the milestones: v7.1.0, v7.2.0 Dec 19, 2024
andrey-medvedev-vk
andrey-medvedev-vk previously approved these changes Dec 28, 2024
View reviewed changes
Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@vkcom-publisher vkcom-publisher added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Jan 5, 2025
@EldarMuhamethanov EldarMuhamethanov removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Jan 10, 2025
@EldarMuhamethanov
Merge branch 'master' into e.muhamethanov/rtl/gallery-improvement
4e2fc3f 
# Conflicts:
#	packages/vkui/src/components/CarouselBase/CarouselBase.tsx
#	packages/vkui/src/components/CarouselBase/helpers.ts
@EldarMuhamethanov EldarMuhamethanov marked this pull request as draft January 14, 2025 14:13
@EldarMuhamethanov EldarMuhamethanov marked this pull request as ready for review January 15, 2025 08:59
@BlackySoul
Copy link
Contributor

2025-01-20.20.19.40.mov

Нет ли здесь косяка - при изменение rtl/ltr стрелки не апдейтаются?

@EldarMuhamethanov
Copy link
Contributor Author

Нет ли здесь косяка - при изменение rtl/ltr стрелки не апдейтаются?

Сейчас в рантайме к сожалению нельзя менять direction, так как он определяется один раз при первой отрисовке. Поэтому при смене direction нужно перезагрузить страницу

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrey-medvedev-vk andrey-medvedev-vk Awaiting requested review from andrey-medvedev-vk

At least 2 approving reviews are required to merge this pull request.

Assignees

@EldarMuhamethanov EldarMuhamethanov

Labels
cmp:gallery type:feature
Projects
VKUI
Status: 👀 In Review
Milestone
v7.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@EldarMuhamethanov @BlackySoul @andrey-medvedev-vk @inomdzhon @vkcom-publisher