Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: double disabled opacity #8123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Dec 26, 2024

  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи
  • Release notes

Описание

FormField и Input накладывает прозрачность на текст, из-за чего текст более прозрачен чем должен быть

Изменения

Убираем двойную прозрачность при состоянии disabled

Release notes

Исправления

  • Поправлена двойная прозрачность у элементов ввода

Убираем двойную прозрачность при состоянии `disabled`
@SevereCloud SevereCloud requested a review from a team as a code owner December 26, 2024 17:49
@SevereCloud SevereCloud self-assigned this Dec 26, 2024
@SevereCloud SevereCloud added this to the v7.1.1 milestone Dec 26, 2024
@github-actions github-actions bot added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Dec 26, 2024
Copy link
Contributor

size-limit report 📦

Path Size
JS 389.42 KB (0%)
JS (gzip) 118.19 KB (0%)
JS (brotli) 97.27 KB (0%)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 342.28 KB (-0.1% 🔽)
CSS (gzip) 42.43 KB (-0.06% 🔽)
CSS (brotli) 33.82 KB (-0.03% 🔽)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit a326ea9

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.55%. Comparing base (ba6b9c4) to head (a326ea9).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8123   +/-   ##
=======================================
  Coverage   95.55%   95.55%           
=======================================
  Files         398      398           
  Lines       11351    11351           
  Branches     3741     3741           
=======================================
  Hits        10847    10847           
  Misses        504      504           
Flag Coverage Δ
unittests 95.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@qurle qurle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

это тянет на релиз года спасибо

Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vkcom-publisher vkcom-publisher added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности
Projects
Status: 👀 In Review
Development

Successfully merging this pull request may close these issues.

5 participants