Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ImageBase): support elementtiming #8127

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

inomdzhon
Copy link
Contributor

@inomdzhon inomdzhon commented Dec 27, 2024

Release notes

Исправления

  • ImageBase: добавлено свойство elementTiming для поддержки elementtiming
  • Avatar: добавлено свойство elementTiming для поддержки elementtiming
  • Image: добавлено свойство elementTiming для поддержки elementtiming

@inomdzhon inomdzhon added cmp:avatar patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча cmp:image-base cmp:image labels Dec 27, 2024
@inomdzhon inomdzhon added this to the v7.1.1 milestone Dec 27, 2024
@inomdzhon inomdzhon self-assigned this Dec 27, 2024
@inomdzhon inomdzhon requested a review from a team as a code owner December 27, 2024 08:47
Copy link
Contributor

github-actions bot commented Dec 27, 2024

size-limit report 📦

Path Size
JS 389.51 KB (+0.02% 🔺)
JS (gzip) 118.23 KB (+0.02% 🔺)
JS (brotli) 97.33 KB (+0.08% 🔺)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 342.61 KB (0%)
CSS (gzip) 42.45 KB (0%)
CSS (brotli) 33.82 KB (0%)

Copy link

codesandbox-ci bot commented Dec 27, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Dec 27, 2024

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

Copy link
Contributor

github-actions bot commented Dec 27, 2024

👀 Docs deployed

Commit 583503e

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.56%. Comparing base (d9cbf49) to head (583503e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8127   +/-   ##
=======================================
  Coverage   95.56%   95.56%           
=======================================
  Files         398      398           
  Lines       11355    11355           
  Branches     3742     3742           
=======================================
  Hits        10851    10851           
  Misses        504      504           
Flag Coverage Δ
unittests 95.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inomdzhon inomdzhon merged commit 4e3ad87 into master Dec 27, 2024
29 checks passed
@inomdzhon inomdzhon deleted the imirdzhamolov/fix/ImageBase-elementtiming branch December 27, 2024 09:27
vkcom-publisher pushed a commit that referenced this pull request Dec 27, 2024
h2. Release notes
h2. Исправления
- ImageBase: добавлено свойство `elementTiming` для поддержки [elementtiming](https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/elementtiming)
- Avatar: добавлено свойство `elementTiming` для поддержки [elementtiming](https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/elementtiming)
- Image: добавлено свойство `elementTiming` для поддержки [elementtiming](https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/elementtiming)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmp:avatar cmp:image cmp:image-base patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants