Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Show only custom permissions as available in guardian admin for API #299

Merged
merged 1 commit into from
Dec 19, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/vng/servervalidation/admin.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

from vng.testsession.models import SessionType

from .forms import CustomAdminUserObjectPermissionsForm, CustomAdminGroupObjectPermissionsForm

def get_all_fields(mo):
l = [field.name for field in mo._meta.fields]
l.remove('id')
Expand Down Expand Up @@ -67,6 +69,13 @@ def get_obj_perms_base_context(self, request, obj):
context["model_perms"] = context["model_perms"].filter(codename__in=permission_codes)
return context

def get_obj_perms_manage_group_form(self, request):
return CustomAdminGroupObjectPermissionsForm

def get_obj_perms_manage_user_form(self, request):
return CustomAdminGroupObjectPermissionsForm


@admin.register(model.PostmanTest)
class PostmanTestAdmin(AdminChangeLinksMixin, OrderedModelAdmin):
list_display = ['name', 'version', 'test_scenario', 'move_up_down_links',
Expand Down
20 changes: 20 additions & 0 deletions src/vng/servervalidation/forms.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
from filer.models.filemodels import File
from django.core.exceptions import ValidationError
from django.utils.translation import gettext_lazy as _
from guardian.admin import AdminUserObjectPermissionsForm, AdminGroupObjectPermissionsForm
from django.forms.models import inlineformset_factory

from tinymce.widgets import TinyMCE
Expand Down Expand Up @@ -211,3 +212,22 @@ class EnvironmentUpdateForm(forms.ModelForm):
class Meta:
model = Environment
fields = ['name']


class CustomPermissionChoicesMixin:
def get_obj_perms_field_choices(self):
"""
Show only the custom permissions as the available object permissions
"""
choices = super().get_obj_perms_field_choices()
permission_codes = [code for code, _ in self.obj._meta.permissions]
choices = [(perm, label) for perm, label in choices if perm in permission_codes]
return choices


class CustomAdminUserObjectPermissionsForm(CustomPermissionChoicesMixin, AdminUserObjectPermissionsForm):
pass


class CustomAdminGroupObjectPermissionsForm(CustomPermissionChoicesMixin, AdminGroupObjectPermissionsForm):
pass