This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Fixed issues with starting Docker images for consumer test sessions #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextreme
reviewed
Aug 1, 2019
| update_session_status(session, _('Check migration status'), int(40 + (6 - len(uwsgi_containers)) * 45 / 6)) | ||
| if len(spawned) == len(uwsgi_containers): | ||
| break | ||
| time.sleep(5) |
There was a problem hiding this comment.
Wellicht dat het handig om hier een soort timeout in te maken? Dat na bijvoorbeeld 60x proberen de taak wordt afgebroken. Ik hou niet echt van oneindige loops zonder failsafe, zeker niet wanneer je afhankelijk bent van een ander systeem.
|
Akkoord om te mergen, wel nog even kijken naar mijn opmerking dan kunnen we volgens mij beter omgaan met zo'n situatie als dit weer optreedt (nette error-melding ipv hangen op de migration stap). |
|
Prima. Ik weet niet of er ook een roll-back / kill-cluster actie is als het misgaat maar dit maakt het in ieder geval duidelijk als er wat aan de hand is. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for VNG-Realisatie/api-test-platform#91