chore: voicevox_onnxruntimeのprepare.bashを使う #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
approved these changes
Dec 30, 2024
Comment on lines
+384
to
+385
| - name: Encrypt the preparation log | ||
| if: failure() && steps.prepare.outcome == 'failure' |
There was a problem hiding this comment.
（ただのリファクタリング案です）
これ、最後のステップで１回だけ実行するのでも良さそうですね！
すべての関連stepで./${{ matrix.artifact_name }}_{stdout,stderr}.txtに>>で追記していって、最後のステップでfailure()のときに./${{ matrix.artifact_name }}_{stdout,stderr}.txtをアップロードするようにしたらコードが１回で済むので便利そう。
There was a problem hiding this comment.
checkout(今は> /dev/null 2>&1)- prepare.bash
- ビルド
の三つがあるので、確かにまとめるとすっきりしそうですね。まあその時は見通し的に1.と2.のstep自体を3.の直前に持って来た方がよさそうなので、別PRの方がよさそうかなと思っています。
Hiroshiba
reviewed
Dec 30, 2024
qryxip
added a commit
that referenced
this pull request
Dec 31, 2024
voicevox_onnxruntimeに関係する次の4つのステップのログを、apeendしてひと まとめにしてartifact化するようにする。 1. `checkout` 2. prepare.bashの実行 3. voicevox_onnxruntimeのビルド 4. ビルドディレクトリの`tree(1)` 残課題として: #65 (comment) Refs: VOICEVOX/voicevox_project#24 Refs: #62 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
voicevox_onnxruntime用のスクリプトをvoicevox_onnxruntime側に移したので、それを使うようにする。
関連 Issue
Refs: VOICEVOX/voicevox_project#24
スクリーンショット・動画など
その他