Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONNX版自動ビルド: cmake --install処理の追加 #36

Merged
merged 4 commits into from
Nov 2, 2021

Conversation

aoirint
Copy link
Member

@aoirint aoirint commented Nov 2, 2021

内容

ONNX版自動ビルドにおいて、
共有ライブラリのビルド後の処理 cmake --install が抜けていたため、追加します。

Linux用ビルドでは、cmake --installを実行しない場合、rpathに$ORIGINが設定されないため、同じディレクトリにおいた共有ライブラリを読み出せない問題があったと思います。

関連 Issue

#33

@aoirint aoirint marked this pull request as ready for review November 2, 2021 17:09
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!
releaseを再作成してみたいと思います!

@Hiroshiba Hiroshiba merged commit a9cbea8 into VOICEVOX:main Nov 2, 2021
@aoirint aoirint deleted the patch-fix-rpath branch October 17, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants