Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[project-vvm-async-api] C/Python APIクレート側のバージョンを出す #507

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Jun 2, 2023

内容

C APIとPython APIが出す"version"を、Rust APIのものではなく各クレート自体のものにします。

#503 (comment)

今までPython APIではパッケージのバージョンが0.14.4+cpuであるにもかかわらず__version__"0.14.4"になっていたという問題もあったので、それも理由です。

関連 Issue

その他

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@Hiroshiba Hiroshiba merged commit 486d3f4 into VOICEVOX:project-vvm-async-api Jun 2, 2023
@qryxip qryxip mentioned this pull request Jun 6, 2023
67 tasks
@qryxip qryxip mentioned this pull request Jul 22, 2023
69 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants