Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Python APIのre-export漏れ #930

Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix: Python APIのre-export漏れ #930

merged 1 commit into from
Jan 23, 2025

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Jan 22, 2025

内容

関連 Issue

その他

@qryxip
Copy link
Member Author

qryxip commented Jan 22, 2025 •
edited
Loading

Sphinxではこんな感じになる。

image

……あれ？ 今気付いたけどStyleVersionって何なんだ…？？
[追記] #931

@qryxip qryxip requested a review from Hiroshiba January 22, 2025 19:54
Hiroshiba
Hiroshiba approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

型のexport漏れは結構起こりやすそうな気がしますねぇ。
これって実際にこの型を使ってる場所のドキュメントでは、その型へのリンクが切れてる感じになるのでしょうか👀
であればドキュメント内にリンク切れのものがあるかどうかのCIを回すのもアリかもとアイデアが浮かんだので、とりあえずコメントまで！

@qryxip qryxip merged commit 28cba0a into VOICEVOX:main Jan 23, 2025
30 checks passed
@qryxip qryxip deleted the fix-re-exports-in-python-api branch January 23, 2025 03:32
@qryxip
Copy link
Member Author

qryxip commented Jan 23, 2025

Sphinxだとどうなんでしょうね…？ 多分それを成すためには四苦八苦しそうな予感がしています。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qryxip @Hiroshiba