Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

整理: SettingHandler テストの想定出力を変更 #1410

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented Jun 19, 2024

内容

#1407 (comment) に従い SettingHandler テストの true value を変更するリファクタリングを提案します。

関連 Issue

ref #1407 (comment)

@tarepan tarepan requested a review from a team as a code owner June 19, 2024 18:29
@tarepan tarepan requested review from Hiroshiba and removed request for a team June 19, 2024 18:29
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hiroshiba Hiroshiba merged commit 215997f into VOICEVOX:master Jun 20, 2024
4 checks passed
@tarepan tarepan deleted the refactor/setting_test branch June 20, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants