Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readmeに過去のバージョンのコアの使用方法を追記 #300

Merged
merged 4 commits into from
Feb 1, 2022

Conversation

takana-v
Copy link
Member

@takana-v takana-v commented Jan 24, 2022

内容

題の通り

関連 Issue

close #298

その他

#254 の変更が含まれていますので、release-0.10へは含めないようにお願いします。

@github-actions
Copy link

github-actions bot commented Jan 24, 2022

Coverage Result

Resultを開く
Name Stmts Miss Cover
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/acoustic_feature_extractor.py 75 0 coverage-100%
voicevox_engine/dev/synthesis_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/synthesis_engine/mock.py 29 0 coverage-100%
voicevox_engine/full_context_label.py 167 5 coverage-97%
voicevox_engine/kana_parser.py 87 1 coverage-99%
voicevox_engine/model.py 71 7 coverage-90%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetLoader.py 34 1 coverage-97%
voicevox_engine/preset/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 5 0 coverage-100%
voicevox_engine/synthesis_engine/core_wrapper.py 148 130 coverage-12%
voicevox_engine/synthesis_engine/make_synthesis_engines.py 47 39 coverage-17%
voicevox_engine/synthesis_engine/synthesis_engine.py 101 0 coverage-100%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 53 5 coverage-91%
voicevox_engine/utility/init.py 2 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 35 3 coverage-91%
TOTAL 876 191 coverage-78%

@takana-v takana-v requested review from Hiroshiba and aoirint January 24, 2022 18:01
@coveralls
Copy link

coveralls commented Jan 24, 2022

Pull Request Test Coverage Report for Build 1778611423

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 29 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.05%) to 78.196%

Files with Coverage Reduction New Missed Lines %
voicevox_engine/synthesis_engine/synthesis_engine_base.py 1 90.57%
voicevox_engine/synthesis_engine/core_wrapper.py 28 12.16%
Totals Coverage Status
Change from base Build 1740722558: 0.05%
Covered Lines: 685
Relevant Lines: 876

💛 - Coveralls

Copy link
Member

@PickledChair PickledChair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mac の場合は記載の方法では起動できないので、それについてコメントしました(Mac では未サポートとするという話もあった気がした(LibTorch についてだけでしたでしょうか?)ので、Mac についてはあえて何も書かない、というのもありなのかもしれませんが、一応言及しました……)。

また、これはメモなのですが、 VOICEVOX/voicevox_core#70 で Mac 版のコアライブラリのファイル名が libcore_cpu_x64.dylib から libcore_cpu_universal2.dylib に変わったので、Mac ではプレビュー版のコア( 0.10.preview.* )が使用できなくなりました。これらのコアのサポートを切ると仮定して、README でそれに言及すべきかどうか少し迷うところだと感じました……(言及する必要があるほど需要がある情報とも思えなかったので……)。

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@takana-v takana-v requested a review from PickledChair January 28, 2022 15:20
Copy link
Member

@PickledChair PickledChair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

README.md Outdated Show resolved Hide resolved
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

過去バージョンのコアを使う方法をREADMEで案内する
4 participants