Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

READMEの変更漏れを修正 #332

Merged
merged 2 commits into from
Feb 20, 2022
Merged

Conversation

takana-v
Copy link
Member

内容

#254 にてmockの使用には--enable_mock引数が必要になりましたが、readmeを変更するのを忘れていました。
また、ビルド引数も古いままだったので修正します。

その他

@.PickledChair さんのツイートで気づくことができました、ありがとうございます。
https://twitter.com/pickled_chair/status/1495039654902792198

@takana-v takana-v requested a review from Hiroshiba February 19, 2022 19:02
@github-actions
Copy link

Coverage Result

Resultを開く
Name Stmts Miss Cover
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/acoustic_feature_extractor.py 75 0 coverage-100%
voicevox_engine/dev/synthesis_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/synthesis_engine/mock.py 36 2 coverage-94%
voicevox_engine/full_context_label.py 171 6 coverage-96%
voicevox_engine/kana_parser.py 86 1 coverage-99%
voicevox_engine/model.py 75 7 coverage-91%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetLoader.py 34 1 coverage-97%
voicevox_engine/preset/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 5 0 coverage-100%
voicevox_engine/synthesis_engine/core_wrapper.py 164 146 coverage-11%
voicevox_engine/synthesis_engine/make_synthesis_engines.py 52 44 coverage-15%
voicevox_engine/synthesis_engine/synthesis_engine.py 108 2 coverage-98%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 62 7 coverage-89%
voicevox_engine/utility/init.py 2 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 35 3 coverage-91%
TOTAL 927 219 coverage-76%

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

失念していました、修正等ありがとうございます・・・!

@Hiroshiba Hiroshiba merged commit 22de8dc into VOICEVOX:master Feb 20, 2022
@takana-v takana-v deleted the fix-readme-mock branch February 20, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants