Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: apply、updateをupsertに統合 #10

Merged
merged 1 commit into from
Apr 16, 2023

Conversation

sevenc-nanashi
Copy link
Member

内容

insert・updateをupsertに統合します。

関連 Issue

スクリーンショット・動画など

(なし)

その他

(なし)

@sevenc-nanashi sevenc-nanashi changed the title Change: insert、updateをupsertに統合 Change: apply、updateをupsertに統合 Apr 15, 2023
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

もしよかったら動作確認のとこのコードも実行してもらえると・・・!!
https://github.com/VOICEVOX/voicevox_telemetry_gas/tree/c631c191323465cbc432103ed4e9a4646a188747#%E5%8B%95%E4%BD%9C%E7%A2%BA%E8%AA%8D

(apply_wordに対応してたのでたぶん動かないはず)

@sevenc-nanashi
Copy link
Member Author

deployCheckは実行しましたー。

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あ! scripts/deployCheck.tsも変更してくださってたの気づきませんでした。。

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@Hiroshiba Hiroshiba merged commit c014b1e into VOICEVOX:main Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants