Integrate Azure into GCP's magic-modules #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
November 14, 2018 17:42
add subcategory header to document template
…ucture Search example consider foder struct by autorest.cli
don't set Default for output-only property
when searching folder form example, considering suffix of "-preview"
disable the comment at header
Confrom new tf provider style
follow new client get scheme for datasource
put generated files to internal/services/<rp> folder
Testcase Impl. Change & Package name Change (according to provider refactor)
add default timeout for d/r
resource group name case sensitive
remove `sidebar_current` from gen doc
Terraform azure provider currently introduce custom parseID function, which is to replace previous `azure.ParseAzureResourceID()`. Furthermore, this is used at `Importer` to validate importing ID and in acctest.
Support custom parseID function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we integrate Azure-specific logic and coding templates into GCP's original magic-modules. We put all azure-specific code in
azurefolders, and only inject the least amount of code into original files.We also support running magic-modules side-by-side, by using the
--cloudswitch. By default we will use GCP templates and logic, so it will not affect any existing magic-modules user code.