Moved callback for async path finish to after the task is fully cleaned up #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly cleaned up (i.e. owner removed from task owner list), fixing a bug where asking for a new path in the callback of an old path would cause an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! Thanks so much for making this plugin -- it's been really great to work in!
In the current version of DoN, calling SchedulePathfindingTask from the Result Handler Delegate of an earlier SchedulePathfindingTask throws an error because the callback is invoked before the task is fully cleaned up.
An example use case would be an actor that's iteratively querying paths to different targets in order to choose the best one to take. DoN only allows one active pathfinding task at a time, so this actor will need to schedule new tasks immediately as the old ones finish.
This case is tested to work after swapping these two lines of code!