Concrete memory and unsafe operations fixes #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oveeernight
requested changes
Jun 6, 2024
VSharp.SILI.Core/MemoryRegion.fs
Outdated
| list { | ||
| let! g, accLbs, accUbs = acc | ||
| let! gl, l = Merging.unguardGvs lb | ||
| let! gu, u = Merging.unguardGvs ub | ||
| return (g &&& gl &&& gu, l::accLbs, u::accUbs) | ||
| }) | ||
| } | ||
| let boundsPairs = List.foldBack2 unGuard lowerBounds upperBounds [True(), [], []] |
There was a problem hiding this comment.
List.empty для единообразия?
| @@ -420,7 +427,7 @@ type stackBufferIndexKey = | |||
| override x.Map mapTerm _ _ reg = | |||
| reg, {index = mapTerm x.index} | |||
| override x.IsUnion = | |||
| match x.index.term with | |||
| match x.index.term with // TODO: #Roma | |||
There was a problem hiding this comment.
вроде эту странную реализацию удалить хотели вообще...
| @@ -631,14 +638,13 @@ module private UpdateTree = | |||
| PersistentDict.append modifiedTree disjoint |> Node | |||
| List.foldBack writeOneKey disjointUnguardedKey tree | |||
|
|
|||
|
|
|||
| let map (mapKey : 'reg -> 'key -> 'reg * 'key) mapValue (tree : updateTree<'key, 'value, 'reg>) predicate = | |||
| let map (mapKey : 'reg -> 'key -> 'reg * 'key) mapValue (tree : updateTree<'key, term, 'reg>) predicate = | |||
| let mapper reg {key=k; value=v; guard = g; time = t} = | |||
There was a problem hiding this comment.
Suggested change
| let mapper reg {key=k; value=v; guard = g; time = t} = | |
| let mapper reg {key = k; value = v; guard = g; time = t} = |
- fixed unsafe operations - added style fixes
oveeernight
approved these changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.