Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI based on Github Actions #21

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

martin-g
Copy link

Builds on Linux x86_64 (native) and aarch64 (emulated via QEMU).

@martin-g
Copy link
Author

martin-g commented Oct 19, 2022

It is a draft because there are still some errors in the build - https://github.com/martin-g/v3d_external/actions/runs/3281478805/.
I would be thankful for any help!

Builds on Linux x86_64 and aarch64

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@martin-g martin-g force-pushed the ci-github-actions branch 3 times, most recently from e596a1a to 0d0c1ed Compare October 20, 2022 09:13
The Azure one fails with:

The following packages have unmet dependencies:
 libomp-dev : Depends: libomp5 (= 5.0.1-1)
E: Unable to correct problems, you have held broken packages.

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@martin-g martin-g force-pushed the ci-github-actions branch 2 times, most recently from 585423d to c07bfd5 Compare October 20, 2022 09:20
This is needed because of:

The repository will be downloaded using the GitHub REST API
To create a local Git repository instead, add Git 2.18 or higher to the PATH
Error: Input 'submodules' not supported when falling back to download using the GitHub REST API. To create a local Git repository instead, add Git 2.18 or higher to the PATH.

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
gcc-4.8 and g++-4.8 are available in stock Ubuntu 18.04 Docker images

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@martin-g martin-g marked this pull request as ready for review October 21, 2022 16:05
@martin-g
Copy link
Author

martin-g commented Oct 21, 2022

I think the PR is ready for review.
A CI run with its logs could be seen at my fork: CI

@martin-g
Copy link
Author

martin-g commented Nov 2, 2022

Any feedback on the proposed changes ?

Copy link

@julien-faye julien-faye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Having CI on Linux ARM64 would be awesome!

Copy link

@markjens markjens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I also needed to build on Linux ARM64 and this CI workflow helped me a lot to figure out the needed prerequisites!
Well done. @martin-g !

Copy link

@emiliofernandes emiliofernandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, @martin-g !
This PR is really helpful to get the correct dependencies and build steps !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants