Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode #74

Open
wants to merge 24 commits into
base: dev
Choose a base branch
from
Open

Dark mode #74

wants to merge 24 commits into from

Conversation

AbishekSh
Copy link
Contributor

Dark mode works!!!!! (seizure warning)

paulbruzzi and others added 23 commits November 10, 2023 21:24
@paulbruzzi
Added pin placeholder
b005a41
@paulbruzzi
Merge remote-tracking branch 'origin' into pin_in_building
23bfe72
@paulbruzzi
Made Pin show
1152870
@paulbruzzi
Added boolean check for pin
ae58bf4
@paulbruzzi
Created base for pin item
584ad48
@paulbruzzi
continued to setup pin
902d127
@paulbruzzi
Pin placeholder ordered correctly
070bb22
@paulbruzzi
Added separate pin vue
31d7381
@paulbruzzi
added Dark mode button placeholder
94da64b
@paulbruzzi
Simplified the method for changing to darkmode
26cc53e
@paulbruzzi
added a global variable for dark mode
7de8079
@paulbruzzi
added a watcher for global darkmode variable
2219b66
@paulbruzzi
Merge branch 'dev' into dark_mode
d6c8957
@paulbruzzi
added placehoder color switches
f253969
@paulbruzzi
Added placeholder logic for darkmode
cc35e47
@AbishekSh
Added SVGs for Ricketts (3-5)
283d2e6
@AbishekSh
Merge branch 'dev' into dark_mode
8c35776
@AbishekSh
tried to get the background to change color
61e7ef5
@AbishekSh
added a function for dark mode on main.js (it doesnt change preferred…
881d70a 
…colorscheme yet)
@AbishekSh
DARK MODE WORKS!!! it may flashbang you
079316f
@AbishekSh
removed some console logs
6435d50
@AbishekSh
the logo now changes when u enable dark mode
8e3a926
@paulbruzzi
Merge branch 'dev' into dark_mode
b419776
paulbruzzi
paulbruzzi requested changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@paulbruzzi paulbruzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you open a buidling's floorplan the fade for the image is white

@Acumane
Copy link
Member

Acumane commented Apr 18, 2024

  • Needs a cohesive dark color palette
  • Black next on dark popup
  • White gradients around image, as Paul mentioned
  • Breaks bldg heat colors on page load
  • Toggle button icon

Not yet a /live candidate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbruzzi paulbruzzi paulbruzzi requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AbishekSh @Acumane @paulbruzzi