Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Fixed search dropdown suggestions overlapping with filter options successfully issue 599 #602

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

MeetDOD
Copy link
Contributor

@MeetDOD MeetDOD commented Oct 7, 2024

Pull Request Resolves [#599 ]

Title: Fixed search dropdown suggestions overlapping with filter options successfully.

Description

  1. Responsive Layout: Utilized flex with flex-col sm:flex-row to stack elements vertically on small devices and horizontally on medium and large devices.
  2. Sort Feature: Wrapped the sort section in a div with the following classes:
    mb-2 sm:mb-0: Adds margin below on small screens, removed on larger screens.
  3. Search Input and Button: Wrapped the search input and button in a flex container to keep them aligned and together.
    Used w-full sm:w-auto on the input to allow it to take the full width on small screens and auto width on larger screens.
  4. Margin Adjustments for Suggestions: Adjusted the suggestion dropdown with classes:
    ml-0 md:ml-52: Set left margin to 0 on small screens and 52 on medium and larger screens to align with the overall layout.
  5. Accessibility: Included placeholder text and functionality for pressing "Enter" to initiate a search.
  6. Search Button: Styled the search button with Tailwind CSS classes for hover effects and transitions.

Related Issues

Fixes #599

Changes Made

Bug fixes: Fixed search dropdown suggestions overlapping with filter options.

Screenshots

image

image

I certify that I have carried out the relevant code of conduct and provided the requisite screenshot for validation by submitting this pull request.

Thank You for this contribution.

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 1:51pm

Copy link

github-actions bot commented Oct 7, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@VaibhavArora314 VaibhavArora314 merged commit 47ef56c into VaibhavArora314:main Oct 7, 2024
4 checks passed
Copy link

github-actions bot commented Oct 7, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Search Dropdown Suggestions Overlapping with Filter Options
2 participants