Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vite-svelte example #40

Merged
merged 3 commits into from
Jun 27, 2024
Merged

add vite-svelte example #40

merged 3 commits into from
Jun 27, 2024

Conversation

jeromeleong
Copy link
Contributor

It is a template for Svelte SSR with Salvo-rs and Vite.

@Valerioageno Valerioageno self-requested a review June 26, 2024 19:30
Copy link
Owner

@Valerioageno Valerioageno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a great addition!
Two things are missing for merging it:

  1. Add the example link from into the main Cargo.toml
[[example]]
name="vite-svelte"
path="examples/vite-svelte/backend/main.rs"
  1. Build a server side bundle and put it into the tests/assets folder , then create a test file for svelte tests/svelte.rs. This will ensure next improvements won't break the svelte implementation

Thanks for it

@jeromeleong jeromeleong reopened this Jun 27, 2024
@Valerioageno
Copy link
Owner

Thanks for the addition. Please fix the Rustfmt pipeline so we can merge it into main.

@Valerioageno Valerioageno self-requested a review June 27, 2024 07:17
Copy link
Owner

@Valerioageno Valerioageno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Valerioageno Valerioageno merged commit 103863e into Valerioageno:main Jun 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants