workaround bug in clang 18 #1583
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note that the clang bug should be fixed in clang versions >=19
|
Do you want to enable the CI again too? |
Yea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note that the clang bug should be fixed in clang versions >=19
Also currently, only line 20138 needs to be edited to
fixall compile errors currently encountered when trying to compile w/ clang 18, but this PR also addresses the other lines where the address of a function fromfunction_detail::upvalue...is taken, to avoid needing to make future workaround PRs for the same clang bug.