Various fixes to Vanta install script #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use || as or operator instead of -o which can have incorrect results and is deprecated. Use -n instead of double negation '! -z'. Quote variables to prevent word splitting and whitespace problems
|
BTW is there any particular reason the version isn't the latest (2.3.0)? |
|
We plan to slowly release 2.3.0 to agents with auto-updates enabled, so we don't plan to update the script until it's fully rolled out. Thanks! |
|
Hi! Any plans on reviewing / merging this? or should I perhaps drop this PR if you don't accept contributions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use || as or operator instead of -o which can have incorrect results and is deprecated. Use -n instead of double negation '! -z'. Quote variables to prevent word splitting and whitespace problems