Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if score set has variants before mapping, return error if not #25

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Check if score set has variants before mapping, return error if not #25

merged 2 commits into from
Nov 21, 2024

Conversation

sallybg
Copy link
Collaborator

@sallybg sallybg commented Oct 18, 2024

No description provided.

@sallybg sallybg requested a review from bencap October 18, 2024 18:16
bencap
bencap approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@bencap bencap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bencap bencap changed the base branch from mavedb-main to mavedb-dev November 18, 2024 22:40
@bencap bencap merged commit 4c6012b into mavedb-dev Nov 21, 2024
6 checks passed
@bencap bencap deleted the sallybg/no-map-if-no-variants branch November 21, 2024 00:02
@bencap bencap mentioned this pull request Nov 21, 2024
Merged
@bencap bencap linked an issue Nov 21, 2024 that may be closed by this pull request
Raise an Error if there are no Variants to Map #29
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bencap bencap bencap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Raise an Error if there are no Variants to Map
2 participants
@sallybg @bencap