Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corporea index doesn't localize #4248

Open
gamma-delta opened this issue Dec 19, 2022 · 2 comments · May be fixed by #4249
Open

Corporea index doesn't localize #4248

gamma-delta opened this issue Dec 19, 2022 · 2 comments · May be fixed by #4249

Comments

@gamma-delta
Copy link
Contributor

Mod Loader

Fabric

Minecraft Version

1.19.2

Botania version

1.19.2-436-FABRIC

Modloader version

Quilt Loader 0.17.7 / Quilted Fabric API 4.0.0-beta.24+0.68.0-1.19.2

Modpack info

Spooled (by Moss)

The latest.log file

(there is no crash)

Issue description

Corporea indices can't request anything from the network with their localized name.

Given this setup (there's 60 obsidian in the barrel):

2022-12-19_13 32 34

  • Requesting obsidian won't find any
  • Requesting block.minecraft.obsidian will get you 1 obsidian
  • Same with requesting *

Steps to reproduce

  1. Make a minimal corporea network with a storage chest and an index
  2. Try to request something
  3. Find it only works with the I18n string, not the translation

Other information

I'm sorry, Artemis, for being mean to you.

@gamma-delta gamma-delta linked a pull request Dec 20, 2022 that will close this issue
3 tasks
@Aegide
Copy link
Contributor

Aegide commented Jan 4, 2023

Corporea indices can't request anything from the network with their localized name.

I requested an orechid, using it's french localized name, and it works perfectly fine.

I don't understand your issue.

image

@TheRealWormbo
Copy link
Collaborator

The issue here is for multiplayer games, where the language setting of the client might not necessarily match that of the server. Currently corporea index requests are mostly handled on the server side, including the returned message. Things will get very tricky when the client's language is supposed to be used, as the client doesn't know what items exist in the corporea network and the server doesn't know what language the client actually uses. As a result, default item names would need to be resolved on the client, but renamed items and items with dynamic names (something like "Fluid Tank (Water, 1000mB)") will need to be matched on the server. The issue is that not only does the server not know a client's language setting, it might not even know that language at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants