-
-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corporea string item loading is done client-side #4249
base: 1.19.x
Are you sure you want to change the base?
Conversation
whoops I very cleverly put backticks in the last commit name so it tried to interpret them as commands. it should say "make matching |
Say I have an iron ingot in the system called (I'll run spotless at the end) |
One problem I thought of: it won't work nicely with items that have a different display name per stack irregardless of the display name, like hexcasting scrolls... |
Yes, i'd say this is a goal. Currently not feeling very well but if i get better in the next few days i can test whether it works currently
Can you rephrase? I don't get what you mean
I think you already got the answer to this but, for posterity: No, it shouldn't return the renamed item. |
Consider an item that changes its display name by its NBT, such as a fluid tank that may be named "Empty Tank" or "Tank of {X liquid}" |
Can anything from this PR be salvaged? |
This closes #4248 and also has some other nice effects:
stack of
and such are still Englishy)this
now uses aCorporeaItemStackMatcher
instead of searching for the name of the itemI've done some tests and the following works:
64 stone
with nothing in the system64 kiwen
in Toki Pona gives you the stone after switching back to EnglishTodo: