Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Heisei Dream (partially fixes #4064) #4337

Open
wants to merge 2 commits into
base: 1.19.x
Choose a base branch
from

Conversation

jpenilla
Copy link
Contributor

@jpenilla jpenilla commented Apr 21, 2023

Overrides checks in TargetingConditions that prevented Illagers from attacking each other

Originally wanted to also fix it for mobs using the new AI system (ie Piglins), but that turned out to be a lot more complicated than I was hoping it would be (so I'm leaving it for a future PR).

Does two things:
- Set the ATTACK_TARGET memory for mobs using the new Brain system (ie it works on Piglins now)
- Override checks in TargetingConditions that prevented Illagers from attacking each other
@jpenilla jpenilla marked this pull request as draft April 21, 2023 00:54
@jpenilla jpenilla changed the title Improve Heisei Dream (fixes #4064) Improve Heisei Dream (partially fixes #4064) Apr 21, 2023
Doesn't work as is
@jpenilla jpenilla marked this pull request as ready for review April 21, 2023 01:03
@TheRealWormbo TheRealWormbo added the after-1.21-port This will not be fixed/implemented before the port to 1.21 label Jul 13, 2024
@TheRealWormbo
Copy link
Collaborator

We will likely reimplement this PR after the 1.21 port, using MixinExtras features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
after-1.21-port This will not be fixed/implemented before the port to 1.21
Development

Successfully merging this pull request may close these issues.

2 participants