fix double free caused by Array<InstructionTextToken>

Vector35 · Jun 4, 2024 · 5ae2db4 · 5ae2db4
1 parent a6d7f72
commit 5ae2db4
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/rust/src/disassembly.rs b/rust/src/disassembly.rs
@@ -282,14 +282,14 @@ unsafe impl CoreArrayProviderInner for InstructionTextToken {
 impl CoreArrayProvider for Array<InstructionTextToken> {
     type Raw = BNInstructionTextLine;
     type Context = ();
-    type Wrapped<'a> = Self;
+    type Wrapped<'a> = mem::ManuallyDrop<Self>;
 }
 unsafe impl CoreArrayProviderInner for Array<InstructionTextToken> {
     unsafe fn free(raw: *mut Self::Raw, count: usize, _context: &Self::Context) {
         BNFreeInstructionTextLines(raw, count)
     }
     unsafe fn wrap_raw<'a>(raw: &'a Self::Raw, _context: &'a Self::Context) -> Self::Wrapped<'a> {
-        Self::new(raw.tokens, raw.count, ())
+        mem::ManuallyDrop::new(Self::new(raw.tokens, raw.count, ()))
     }
 }