implement Project, ProjectFile and ProjectFolder in rust #5483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NOTE TO SELF: Once merged, remember to rebase and PR rbran/impl-external-l |
|
Manually rebased and pushed these commits, ty! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I assumed that
BNProjectFileGetCreationTimestampand other time related fields are seconds since the UNIX_EPOCH.I also notice that the CPP implementation is missing the functions
BNFreeProject,BNFreeProjectFileandBNFreeProjectFolder, although it include the implementation for each of these objs. Maybe it's missing the deconstructor and is leaking memory.