Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the user to modify the BV during initialization #5831

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

rbran
Copy link
Contributor

@rbran rbran commented Aug 6, 2024

If the method CustomBinaryView::init don't accept &mut self the user will have difficulty to incorporate args: Self::Args into it's data structure.

@emesare emesare self-requested a review August 6, 2024 13:49
@emesare emesare added the Component: Rust API Issue needs changes to the Rust API label Aug 6, 2024
@emesare emesare self-assigned this Aug 6, 2024
@emesare emesare force-pushed the fix-custombv-init branch from fe7b4f5 to 1c3aa23 Compare August 24, 2024 15:14
@emesare
Copy link
Member

emesare commented Aug 24, 2024

LGTM

@emesare emesare merged commit de23abd into Vector35:dev Aug 24, 2024
2 checks passed
@rbran rbran deleted the fix-custombv-init branch August 24, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Rust API Issue needs changes to the Rust API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants