Simplify Guard API and reduce its use in CoreArrayProvider
#5880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It serves no purpose.
When linking you must depend on the -sys crate
Might want to change this to a in-tree binary later
We link to the core now so these can be ran
Solution was added in the core
Allows language bindings like rust to free register lists sanely
…m rust api Allows language bindings like rust to free conditions lists sanely # Conflicts: # rust/Cargo.lock
emesare
force-pushed
the
rust_break_everything
branch
from
ce5995c to
35fe347
Compare
emesare
force-pushed
the
rust_break_everything
branch
from
35fe347 to
ea111b5
Compare
|
LGTM, committed with 53466cd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of the lifetime parameter
'ainGuard<'a>can be inferred via type checking and doesn't actually need to be directly linked to anownerparameter. Additionally, lots of types whoseWrapped<'a>associated type was aGuard<'a, Self>can instead be made#[repr(transparent)]and their wrapped type changed to&'a Self.A few types still require using
Guardbecause they aren't able to be made#[repr(transparent)], namely:BasicBlockCallingConventionLinearDisassemblyLineCodeReferenceArray<InstructionToken>Also, a few types which weren't able to be marked
#[repr(transparent)]were changed to return an ownedSelfinstead of aGuard:NamedTypedVariableStructureMember