Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SharedCache] Serialize SharedCache::m_symbolInfos #6174

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

WeiN76LQh
Copy link

SharedCache::m_symbolInfos isn't being serialized but there is an attempt to deserialize it. This commit adds in the code to serialize it.

I slightly modified the format because I didn't really understand how it was expected to be serialized based on the deserialization code. The deserialization code looked wrong to me but its likely a misunderstanding on my part. I kept it similar to how m_exportInfos is serialized.

@CLAassistant
Copy link

CLAassistant commented Nov 21, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@0cyn
Copy link
Member

0cyn commented Dec 10, 2024

Hi! I'll be taking a look at this PR in conjunction with #6210, seeing as removing symbol info serialization entirely in favor of using User Symbols may be a better approach.

WeiN76LQh and others added 2 commits December 23, 2024 11:38
`SharedCache::m_symbolInfos` isn't being serialized but there is an attempt to deserialize it. This commit adds in the code to serialize it.

I slightly modified the format because I didn't really understand how it was expected to be serialized based on the deserialization code. The deserialization code looked wrong to me but its likely a misunderstanding on my part. I kept it similar to how `m_exportInfos` is serialized.
…ad v3 symbol list

We should think through a better way of handling upgrades, as v3 can load v2 dbs just fine, but there is no clean way to upgrade the info currently. We need SharedCache ser/des functions in DSCView.cpp
@0cyn 0cyn force-pushed the fix-symbol-info-serialization branch from f990bc8 to d67f08d Compare December 23, 2024 17:16
@0cyn 0cyn merged commit d67f08d into Vector35:dev Dec 23, 2024
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
File Format: SharedCache Issue with the dyld_shared_cache plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants