[SharedCache] Optimize parsing and applying of slide info #6321
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slide info is parsed and applied on the main thread, below the
SharedCache
constructor, when a shared cache is opened. Time spent applying the slide is time that the main thread is blocked. This collection of optimizations cuts the time spent applying the slide roughly in half (125ms to 65ms on a macOS shared cache).The individual changes are:
SLIDEINFO_DEBUG_TAGS
is enabled. Building the vector was the single most expensive operation in the function.ReadULong
rather than the variable-lengthRead
method. The compiler wasn't able to eliminate the call tomemcpy
in the variable-lengthRead
function, and the overhead of callingmemcpy
is non-trivial given the small size of the read and number of times it is called.ParseAndApplySlideInfoForFile
to take a pointer rather than astd::shared_ptr
. This method doesn't need to manipulate the ownership of the object so theshared_ptr
is unnecessary.After these changes the profile shows 80% the time spent below
ParseAndApplySlideInfoForFile
is insideMappedFileAccessor::ReadULong
/MappedFileAccessor::WritePointer
.