Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Part 2] Display logs for client and server #130

Open
wants to merge 20 commits into
base: show-logs
Choose a base branch
from
Open

Conversation

lotif
Copy link
Collaborator

@lotif lotif commented Nov 27, 2024

PR Type

Feature

Short Description

Clickup Ticket(s): https://app.clickup.com/t/8689qq767

Part 2: UI for displaying logs. Part 1: #128

Adding a link to the progress details section for both server and clients, which will open a modal that fetches and displays the logs (see screenshots below). The modal also has an option for refreshing the logs, which will trigger a refetch, and a download option, which will save the logs in a file and download it.
Screenshot 2024-11-27 at 11 29 15

Screenshot 2024-11-27 at 11 34 28

Tests Added

Fully unit tested.

Copy link
Collaborator

@emersodb emersodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will leave this for someone who has any idea as to what's going on in this PR 😂. Sorry I can't do much of a review here ha.

@@ -62,12 +62,6 @@ jobs:
uses: pypa/[email protected]
with:
virtual-environment: .venv/
# Skipping 3 cryptography issues that can't be patched because of FL4Health
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants