-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Part 2] Display logs for client and server #130
Open
lotif
wants to merge
20
commits into
show-logs
Choose a base branch
from
show-logs-ui
base: show-logs
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersodb
reviewed
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will leave this for someone who has any idea as to what's going on in this PR 😂. Sorry I can't do much of a review here ha.
@@ -62,12 +62,6 @@ jobs: | |||
uses: pypa/[email protected] | |||
with: | |||
virtual-environment: .venv/ | |||
# Skipping 3 cryptography issues that can't be patched because of FL4Health |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
for more information, see https://pre-commit.ci
This reverts commit 0fbc5da.
…oks"" This reverts commit a7956f3.
for more information, see https://pre-commit.ci
# Conflicts: # florist/app/jobs/details/page.tsx
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Feature
Short Description
Clickup Ticket(s): https://app.clickup.com/t/8689qq767
Part 2: UI for displaying logs. Part 1: #128
Adding a link to the progress details section for both server and clients, which will open a modal that fetches and displays the logs (see screenshots below). The modal also has an option for refreshing the logs, which will trigger a refetch, and a download option, which will save the logs in a file and download it.
Tests Added
Fully unit tested.