Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download metrics as JSON #132

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Download metrics as JSON #132

merged 3 commits into from
Dec 9, 2024

Conversation

lotif
Copy link
Collaborator

@lotif lotif commented Nov 27, 2024

PR Type

Feature

Short Description

Clickup Ticket(s): https://app.clickup.com/t/868b1x7qr

Adding a button to download the server and client metrics as a json file.
Screenshot 2024-11-27 at 17 50 52

Tests Added

Fully unit tested

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.85%. Comparing base (3cc970e) to head (0d67d47).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
+ Coverage   89.74%   89.85%   +0.10%     
==========================================
  Files          23       23              
  Lines        2107     2129      +22     
  Branches      177      179       +2     
==========================================
+ Hits         1891     1913      +22     
  Misses        216      216              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@emersodb emersodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is simple enough that I think I can review it fairly well and it looks good 🙂

@lotif lotif merged commit a6d0cf3 into main Dec 9, 2024
6 checks passed
@lotif lotif deleted the donwload-metrics branch December 9, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants