-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pick a database to store training results #16
Conversation
# Conflicts: # florist/api/server.py
# Conflicts: # florist/api/clients/mnist.py # florist/api/server.py # florist/tests/integration/api/utils.py # poetry.lock # pyproject.toml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a few small suggestions but all in all looks great!
@jewelltaylor I've addressed your comments, please check again when you have a minute. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
PR Type
Feature
Short Description
Clickup Ticket(s): https://app.clickup.com/t/8687c8g5x
In short, here I'm seeting up MongoDB as the database of choice and also creating a new database entity and API route just to startup and test the database.
In details, I am:
pymongo
andpydantic
to our dependenciesJob
entity to store information about training jobs. NOTE: this is not final and will change a lot over time as we add more and more functionality.If you want to test this yourself:
yarn dev
localhost:8000/api/server/job
and add the following to the request body as a raw json:You should receive a response with the new record created in the database.
Tests Added
florist/tests/integration/api/routes/server/test_job.py