Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kickstart the repo with the template code #3

Merged
merged 13 commits into from
Feb 15, 2024
Merged

Kickstart the repo with the template code #3

merged 13 commits into from
Feb 15, 2024

Conversation

lotif
Copy link
Collaborator

@lotif lotif commented Feb 7, 2024

PR Type

Feature

Short Description

Clickup Ticket(s): https://app.clickup.com/t/86877agzf

Applying the template to a Next.js+FastAPI application. Using the template app from https://github.com/digitros/nextjs-fastapi

Currently it is loading the app on the localhost root and there is a stub "hello world" python endpoint. Instructions on how to start up the server coming in a follow up ticket (https://app.clickup.com/t/86877aha9).

Tests Added

NA

@lotif lotif changed the title [FLorist] Kickstart the repo with the template code Kickstart the repo with the template code Feb 7, 2024
florist/api/index.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@jewelltaylor jewelltaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the small things I mentioned, I think this looks great! I was able to run it locally and go through the code to understand it.

@lotif lotif merged commit 7535f0f into main Feb 15, 2024
1 check passed
@lotif lotif deleted the nextjs-template branch February 15, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants