Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bugs found while preparing for the in demo #69

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Fixing bugs found while preparing for the in demo #69

merged 2 commits into from
Jun 27, 2024

Conversation

lotif
Copy link
Collaborator

@lotif lotif commented Jun 27, 2024

PR Type

Fix

Short Description

Clickup Ticket(s): NA

Fixing bugs found while preparing for the in demo, namely:

  • Saving a new job would format server config inappropriately. Fixing it to the proper format before sending data to be saved.
  • Numeric values for server config were being submitted as strings, which breaks Flower clients. Fixing it by automatically converting numeric strings into numbers.
  • Adding a loading state to the start training button so we have a visual indication that the call is still running.

Tests Added

Changed existing tests accordingly

@lotif lotif requested a review from jewelltaylor June 27, 2024 19:13
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 91.74%. Comparing base (b7092dc) to head (76247fc).

Files Patch % Lines
florist/app/jobs/page.tsx 66.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
- Coverage   91.96%   91.74%   -0.22%     
==========================================
  Files          21       21              
  Lines        1331     1357      +26     
  Branches       78       82       +4     
==========================================
+ Hits         1224     1245      +21     
- Misses        107      112       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

title="Start"
>
<i className="material-icons text-sm">play_circle_outline</i>
{isLoading || response ? (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

Copy link
Contributor

@jewelltaylor jewelltaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runs on my side and I can see that the logs are being added throughout training on a successful submission! Like the addition of the loading button to for start :)

@lotif lotif merged commit 3064482 into main Jun 27, 2024
8 checks passed
@lotif lotif deleted the demo-bugs branch June 27, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants