-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLorist] Job progress #94
Conversation
…e updated, last cosmetic changes. WIP: needs tests.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
==========================================
+ Coverage 93.23% 93.94% +0.70%
==========================================
Files 23 23
Lines 1685 1981 +296
Branches 107 163 +56
==========================================
+ Hits 1571 1861 +290
- Misses 114 120 +6 ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
Bumps [next](https://github.com/vercel/next.js) from 14.1.1 to 14.2.10. - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](vercel/next.js@v14.1.1...v14.2.10) --- updated-dependencies: - dependency-name: next dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
…2.10' into job-progress
Bumps [mskelton/setup-yarn](https://github.com/mskelton/setup-yarn) from 2 to 3. - [Release notes](https://github.com/mskelton/setup-yarn/releases) - [Commits](mskelton/setup-yarn@v2...v3) --- updated-dependencies: - dependency-name: mskelton/setup-yarn dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…on/setup-yarn-3' into job-progress
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spent a bunch of time going through the code and testing the UI and everything looks great!
@jewelltaylor awesome, thanks! |
PR Type
Feature
Short Description
Clickup Ticket(s): https://app.clickup.com/t/8689q5t5r
Adding progress bar and metrics to job details page (see screenshots below).
Additionally, changing the metrics listener to update the metrics every time it changes so we can see the changes in the page.
Tests Added
Fully unit tested.