Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLorist] Job progress #94

Merged
merged 14 commits into from
Sep 25, 2024
Merged

[FLorist] Job progress #94

merged 14 commits into from
Sep 25, 2024

Conversation

lotif
Copy link
Collaborator

@lotif lotif commented Sep 16, 2024

PR Type

Feature

Short Description

Clickup Ticket(s): https://app.clickup.com/t/8689q5t5r

Adding progress bar and metrics to job details page (see screenshots below).

Additionally, changing the metrics listener to update the metrics every time it changes so we can see the changes in the page.

Screenshot 2024-09-16 at 17 19 18
Screenshot 2024-09-16 at 17 19 30

Tests Added

Fully unit tested.

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 98.04560% with 6 lines in your changes missing coverage. Please review.

Project coverage is 93.94%. Comparing base (b3dac16) to head (193da5e).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
florist/app/jobs/details/page.tsx 97.93% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
+ Coverage   93.23%   93.94%   +0.70%     
==========================================
  Files          23       23              
  Lines        1685     1981     +296     
  Branches      107      163      +56     
==========================================
+ Hits         1571     1861     +290     
- Misses        114      120       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lotif and others added 7 commits September 17, 2024 10:01
Bumps [next](https://github.com/vercel/next.js) from 14.1.1 to 14.2.10.
- [Release notes](https://github.com/vercel/next.js/releases)
- [Changelog](https://github.com/vercel/next.js/blob/canary/release.js)
- [Commits](vercel/next.js@v14.1.1...v14.2.10)

---
updated-dependencies:
- dependency-name: next
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [mskelton/setup-yarn](https://github.com/mskelton/setup-yarn) from 2 to 3.
- [Release notes](https://github.com/mskelton/setup-yarn/releases)
- [Commits](mskelton/setup-yarn@v2...v3)

---
updated-dependencies:
- dependency-name: mskelton/setup-yarn
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Copy link
Collaborator

@jewelltaylor jewelltaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spent a bunch of time going through the code and testing the UI and everything looks great!

@lotif
Copy link
Collaborator Author

lotif commented Sep 25, 2024

@jewelltaylor awesome, thanks!

@lotif lotif merged commit bdb5369 into main Sep 25, 2024
8 checks passed
@lotif lotif deleted the job-progress branch September 25, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants