Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created date parsing and reconciliation systems for robust date handling. #548

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

KadenMc
Copy link
Collaborator

@KadenMc KadenMc commented Jan 18, 2024

PR Type ([Feature | Fix | Documentation | Test])

Feature

Short Description

Added robust component-wise date parsing. Added date reconciliation wherein typos and systemic date entry errors can be identified.
Note: Proper integration required.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clean up this module a bit - function type annotations, docstrings, and removal of unused commented out code.

import numpy as np
import pandas as pd

from cyclops.data.df.series_validation import to_frame_if_series
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The to_frame_if_series method is missing from the original code. Please add.

return pd.concat([date_comps, time_comps], axis=1)


# def find_dates(text):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want to keep this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants