Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to using pandas based batched query, removing dask as a depend… #4

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

amrit110
Copy link
Member

@amrit110 amrit110 commented Nov 2, 2023

…ency

PR Type ([Feature | Fix | Documentation | Test])

Fix, test

Short Description

Batched query can be done using Kaden's implementation instead of using dask. Will make the tool more lightweight.

Tests Added

...

@amrit110 amrit110 self-assigned this Nov 2, 2023
@amrit110 amrit110 added the refactor Refactor existing code label Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #4 (c8372f7) into main (83188e5) will increase coverage by 5.35%.
The diff coverage is 83.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   78.22%   83.57%   +5.35%     
==========================================
  Files          17       17              
  Lines        1832     1869      +37     
==========================================
+ Hits         1433     1562     +129     
+ Misses        399      307      -92     
Files Coverage Δ
cycquery/utils/file.py 99.07% <100.00%> (+62.32%) ⬆️
cycquery/interface.py 90.00% <70.00%> (-4.55%) ⬇️
cycquery/orm.py 94.07% <93.33%> (+0.80%) ⬆️
cycquery/ops.py 80.87% <37.50%> (-0.42%) ⬇️

... and 2 files with indirect coverage changes

Impacted file tree graph

@amrit110 amrit110 merged commit 57f7efc into main Nov 2, 2023
6 checks passed
@amrit110 amrit110 deleted the replace_dask_with_pandas_batched_uqery branch November 2, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant