-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Play preset #33
Merged
dukeofphilberg
merged 8 commits into
Velleman:main
from
daniel-simpson:feature/play-preset
Aug 23, 2024
Merged
Feature: Play preset #33
dukeofphilberg
merged 8 commits into
Velleman:main
from
daniel-simpson:feature/play-preset
Aug 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dukeofphilberg
suggested changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good addition!
dukeofphilberg
suggested changes
Aug 21, 2024
daniel-simpson
force-pushed
the
feature/play-preset
branch
from
August 23, 2024 06:23
707177e
to
8feedd7
Compare
Ready for review |
dukeofphilberg
approved these changes
Aug 23, 2024
Thank you very much! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a function to play a preset via the HTTP API.
As per discussion in #31, I was unable to find a similar API endpoint to play the "Next" preset (similar to
MCU+KEY+NXT
), so that functionality would require the TCPUART API alongside the HTTP one.