Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Play preset #33

Merged
merged 8 commits into from
Aug 23, 2024

Conversation

daniel-simpson
Copy link
Contributor

Adds a function to play a preset via the HTTP API.

As per discussion in #31, I was unable to find a similar API endpoint to play the "Next" preset (similar to MCU+KEY+NXT), so that functionality would require the TCPUART API alongside the HTTP one.

Copy link
Contributor

@dukeofphilberg dukeofphilberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition!

src/linkplay/bridge.py Outdated Show resolved Hide resolved
src/linkplay/bridge.py Outdated Show resolved Hide resolved
tests/linkplay/test_bridge.py Outdated Show resolved Hide resolved
@daniel-simpson
Copy link
Contributor Author

Ready for review

@dukeofphilberg dukeofphilberg self-requested a review August 23, 2024 08:38
tests/linkplay/test_bridge.py Outdated Show resolved Hide resolved
@dukeofphilberg
Copy link
Contributor

Thank you very much! 🎉

@dukeofphilberg dukeofphilberg merged commit 0749b24 into Velleman:main Aug 23, 2024
3 checks passed
@daniel-simpson daniel-simpson deleted the feature/play-preset branch August 25, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants